Enable Node streams by default#94311
Merged
timneutkens merged 4 commits intoJun 2, 2026
Merged
Conversation
Contributor
Stats cancelledCommit: 097ed49 |
Contributor
Tests PassedCommit: 097ed49 |
unstubbable
reviewed
Jun 1, 2026
Contributor
unstubbable
left a comment
unstubbable
left a comment
There was a problem hiding this comment.
Why do we need any test changes in this PR? Shouldn't those tests already have been verified with Node streams in the specific jobs that this PR deletes?
timneutkens
force-pushed
the
codex/use-node-streams-default-on
branch
2 times, most recently
from
5691661 to
94a44c2
Compare
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
timneutkens
force-pushed
the
codex/use-node-streams-default-on
branch
from
6f1b5b1 to
47190a9
Compare
timneutkens
changed the base branch from
canary
to
hl/fix-node-streams-debug-channel-close
Base automatically changed from
hl/fix-node-streams-debug-channel-close
to
canary
June 2, 2026 12:46
timneutkens
force-pushed
the
codex/use-node-streams-default-on
branch
from
3171e36 to
591c269
Compare
timneutkens
force-pushed
the
codex/use-node-streams-default-on
branch
from
591c269 to
097ed49
Compare
timneutkens
changed the base branch from
canary
to
codex/node-stream-test-updates
unstubbable
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Defaults
experimental.useNodeStreamstotruewhile keeping the experimental config flag and explicitfalseopt-out available. Removes redundant dedicated node-stream CI jobs because the ordinary path exercises Node streams after this change.Depends on the standalone test compatibility update in #94347, which intentionally remains outside the Node streams PR stack.
Why?
Node streams can be exercised through the standard Node.js App Router test path once they are the default, allowing a smaller rollout before the larger follow-up that removes the flag and obsolete plumbing.
CI exposed one necessary compatibility fix for this intermediate state: projects with a
next.config.*received the new default after raw experimental-feature processing, leaving the runtime stream selector on the web implementation while compiled app code selected Node stream helpers.How?
defaultConfig.experimental.useNodeStreamstotrue.__NEXT_USE_NODE_STREAMSfrom the fully resolved config, including cached and standalone resolved configs, so defaults and adapter modifications are reflected at runtime.experimental: { useNodeStreams: false }opt-out; edge bundles continue to define the stream flag asfalse.Verification
Run before extracting the prerequisite assertion changes into #94347:
pnpm --filter=next typespnpm --filter=next buildIS_WEBPACK_TEST=1 __NEXT_EXPERIMENTAL_STRICT_ROUTE_TYPES=true pnpm test-start-webpack test/e2e/app-dir/ppr-root-param-fallback/ppr-root-param-fallback.test.tsIS_TURBOPACK_TEST=1 TURBOPACK_BUILD=1 __NEXT_EXPERIMENTAL_STRICT_ROUTE_TYPES=true pnpm test-start-turbo test/e2e/app-dir/ppr-root-param-fallback/ppr-root-param-fallback.test.tsIS_WEBPACK_TEST=1 __NEXT_EXPERIMENTAL_STRICT_ROUTE_TYPES=true pnpm test-start-webpack test/e2e/app-dir/use-server-inserted-html/use-server-inserted-html.test.tspnpm test-dev-webpack test/e2e/app-dir/ppr-root-param-fallback/ppr-root-param-fallback.test.ts test/e2e/app-dir/use-server-inserted-html/use-server-inserted-html.test.tspnpm test-dev-turbo test/e2e/app-dir/ppr-root-param-fallback/ppr-root-param-fallback.test.ts test/e2e/app-dir/use-server-inserted-html/use-server-inserted-html.test.tspnpm test-start-webpack test/production/app-dir/use-node-streams-env-precedence/use-node-streams-env-precedence.test.tspnpm test-start-webpack test/e2e/app-dir/app/standalone.test.ts